Update for stac-fastapi v2.5.x #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
reviewed
Apr 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
alright, tests do pass so ✅ Note: tests pass but it's kinda lucky because we add the prefix to the base_url, while it should be something separate. We don't need to change anything right now but in the future, we should refactor the tests |
Member
|
all the comments are resolved, we can go ahead an merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Update for stac-fastapi v2.5.3
PR Checklist:
pre-commithooks pass locallymake test)make docs)